Skip to content

fix(flatpak): system tray permission#5354

Merged
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
haroldm:origin/fix_flatpak_tray_icon
Jun 28, 2026
Merged

fix(flatpak): system tray permission#5354
ReenigneArcher merged 2 commits into
LizardByte:masterfrom
haroldm:origin/fix_flatpak_tray_icon

Conversation

@haroldm

@haroldm haroldm commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Description

Add permissions to the flatpak definition so the sunshine icon tray can be created

Screenshot

Issues Fixed or Closed

Partial fix for #5276 (it doesn't fix the issues with the homebrew package).

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher changed the title fix: flatpak system tray permission fix(flatpak): system tray permission Jun 28, 2026

@ReenigneArcher ReenigneArcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpic but this will make yamllint fail.

Comment thread packaging/linux/flatpak/dev.lizardbyte.app.Sunshine.yml Outdated
haroldm and others added 2 commits June 28, 2026 16:13
Co-authored-by: Dave Lane <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher ReenigneArcher force-pushed the origin/fix_flatpak_tray_icon branch from d19ea6d to fd9b266 Compare June 28, 2026 20:13
@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.53%. Comparing base (86a2538) to head (fd9b266).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5354    +/-   ##
========================================
  Coverage   27.53%   27.53%            
========================================
  Files         113      113            
  Lines       25593    25593            
  Branches    11237    11237            
========================================
  Hits         7048     7048            
- Misses      16448    17016   +568     
+ Partials     2097     1529   -568     
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-amd64 13.31% <ø> (ø)
Homebrew-macos-14 21.00% <ø> (-0.01%) ⬇️
Homebrew-macos-15 21.18% <ø> (ø)
Homebrew-macos-26 21.27% <ø> (ø)
Homebrew-ubuntu-24.04 13.06% <ø> (ø)
Linux-AppImage 12.39% <ø> (ø)
Windows-AMD64 15.26% <ø> (ø)
Windows-ARM64 13.29% <ø> (+<0.01%) ⬆️
macOS-arm64 19.25% <ø> (ø)
macOS-x86_64 18.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 41 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a2538...fd9b266. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 9cb3589 into LizardByte:master Jun 28, 2026
71 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants